Task 50 — Distributed reflection

Phase: 4 Initiative: 20 Status: done Owner: — Slug: distributed-reflection

Goal

Отчёты рефлексии включают производительность peer-агентов, routing-решения, паттерны сбоев и предлагают улучшения: новые skills, routing-правила, peer-связи. Формируют proposals, а не unreviewed prod-изменения.

Acceptance criteria

• PeerMetric and FailurePattern models
• ReflectionProposal and ReflectionProposalStore — structured proposal persistence
• DistributedReflection.CollectPeerMetrics() — health scores, latency, circuit state
• DistributedReflection.CollectFailurePatterns() — failure patterns from audit/CB state
• DistributedReflection.CollectRoutingPatterns() — intent → peer resolution patterns
• DistributedReflection.GenerateProposalsAsync() — circuit-open → NewSkill proposals, low-health → TrustUpdate proposals
• DistributedReflection.GenerateLLMProposalsAsync() — LLM-assisted proposal generation (configurable)
• DistributedReflection.GetPendingProposals(), Approve(), Reject() — human-in-the-loop
• ReflectionProposalConfig in MeshConfig
• DI registration in MeshServiceExtensions
• Unit tests (ProposalStore CRUD, proposal generation, status transitions)
• dotnet build + dotnet test pass

Sub-tasks

• PeerMetric, FailurePattern, RoutingPattern models
• ReflectionProposal, ReflectionProposalStore — structured proposals with JSON persistence
• ReflectionProposalConfig in MeshConfig (AppConfig.cs)
• DistributedReflection — inject RouterHealthTracker, MeshAuditService
• DistributedReflection.CollectPeerMetrics() — peer health, latency, circuit state
• DistributedReflection.CollectFailurePatterns() — failure patterns from CB + audit
• DistributedReflection.CollectRoutingPatterns() — intent → peer resolution patterns
• DistributedReflection.GenerateProposalsAsync() — circuit-open → NewSkill, low-health → TrustUpdate
• DistributedReflection.GenerateLLMProposalsAsync() — LLM-assisted proposals
• DistributedReflection.GetPendingProposals(), Approve(), Reject() — human-in-the-loop API
• DI registration in MeshServiceCollectionExtensions
• Unit tests for ReflectionProposalStore (CRUD, status transitions)
• Unit tests for DistributedReflection (metric collection, proposal generation)
• dotnet build src/agent/Hercules.csproj — 0 errors
• dotnet test --filter "FullyQualifiedName~DistributedReflection" — all pass

Dependencies

• блокирует / опирается на: task_017 — safe-self-improvement
• блокирует / опирается на: task_041 — inter-agent-audit

Validation

dotnet build src/agent/Hercules.csproj                            → 0 errors
dotnet test --filter "FullyQualifiedName~DistributedReflection"  → 14/14 pass
dotnet test --filter "FullyQualifiedName~ReflectionProposalStore" → 12/12 pass
dotnet test tests/Hercules.Agent.Tests/                           → 1338/1348 pass
                                                                  (10 pre-existing failures in OtelServiceTests,
                                                                   NumericValidatorTests, BudgetGuardTests,
                                                                   WasmToolTests, HerculesBusTests — unrelated)

Implementation notes

Bug fix: CollectFailurePatterns() returned empty when auditService was null — circuit breaker check was nested inside the audit null-guard. Fixed by moving CB check outside the guard so it always runs regardless of audit availability.

Risks / Rollback

Перегрузка шумными proposals; rate-limit + ранжирование + человек-в-контуре.

Links

• Backlog: ../backlog.md
• Roadmap (EN): ../../ROADMAP-EN.md
• Roadmap (RU): ../../ROADMAP-RU.md